Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tsc): add Maya as TSC member #801

Merged
merged 2 commits into from
Jul 13, 2023
Merged

chore(tsc): add Maya as TSC member #801

merged 2 commits into from
Jul 13, 2023

Conversation

Mayaleeeee
Copy link
Member

@Mayaleeeee Mayaleeeee commented Jul 13, 2023 •
edited
Loading

I have added my details to the yaml file.
Thank you.

github-actions[bot]
github-actions bot reviewed Jul 13, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

derberg
derberg reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!
Please commit one suggestion that I added, it is related to empty spaces.

also for future remember that PR titles need to follow https://www.conventionalcommits.org/en/v1.0.0/. For now I fixed the PR title for you, please look at the change so you are aware the change direction

MAINTAINERS.yaml Outdated Show resolved Hide resolved
@derberg derberg changed the title Update MAINTAINERS.yaml chore(tsc): add Maya as TSC member Jul 13, 2023
@Mayaleeeee
Copy link
Member Author

Welcome! Please commit one suggestion that I added, it is related to empty spaces.

also for future remember that PR titles need to follow https://www.conventionalcommits.org/en/v1.0.0/. For now I fixed the PR title for you, please look at the change so you are aware the change direction

Thank you for the clarification and for fixing the PR title. I have implemented the necessary changes and will take note of the conventional commit guidelines in the future. Please let me know if there is anything else you want me to do.

derberg
derberg approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, welcome!!!

@derberg
Copy link
Member

derberg commented Jul 13, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit d614d52 into asyncapi:master Jul 13, 2023
@derberg
Copy link
Member

derberg commented Jul 13, 2023

@Mayaleeeee Soon you will be invited to join the AsyncAPI GitHub organization and you will be added to the team that lists all TSC members.

We use this team to mention in different discussions in different places in GitHub where TSC opinion is needed or even voting on some topic. Once TSC is mentioned:

  • You get GitHub notification
  • We also drop notification in our slack in #95_bot-tsc-members-mentioned channel
  • We drop an email to people that subscribed to TSC news here https://www.asyncapi.com/community/tsc

Pick the channel for notifications that you prefer. Welcome aboard! We are excited to have you as part of the team.

@Mayaleeeee
Copy link
Member Author

@Mayaleeeee Soon you will be invited to join the AsyncAPI GitHub organization and you will be added to the team that lists all TSC members.

We use this team to mention in different discussions in different places in GitHub where TSC opinion is needed or even voting on some topic. Once TSC is mentioned:

  • You get GitHub notification
  • We also drop notification in our slack in #95_bot-tsc-members-mentioned channel
  • We drop an email to people that subscribed to TSC news here https://www.asyncapi.com/community/tsc

Pick the channel for notifications that you prefer. Welcome aboard! We are excited to have you as part of the team.

GitHub notification is cool.
And I'm happy to be a member the great TSC🙏🙏.

Thank you once again.

@fmvilas fmvilas mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@quetzalliwrites quetzalliwrites Awaiting requested review from quetzalliwrites quetzalliwrites is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@thulieblack thulieblack Awaiting requested review from thulieblack thulieblack is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mayaleeeee @derberg @asyncapi-bot